Skip to content

show a session expired warning when the session runs out - #14369

Open
Damans227 wants to merge 2 commits into
apache:mainfrom
Damans227:fro-6451-session-expired
Open

show a session expired warning when the session runs out#14369
Damans227 wants to merge 2 commits into
apache:mainfrom
Damans227:fro-6451-session-expired

Conversation

@Damans227

@Damans227 Damans227 commented Oct 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

When your session runs out on any page, the UI shows a red "Unauthorized" popup that says "Session expired, authorization verification failed." and stays until you close it. It reads like something broke, when all that happened is the login timed out. This changes it to an orange "Session Expired" warning that says "Your session has expired. Please sign in again to continue." and goes away by itself. #14054 already stopped the popup on the login page itself, this covers the real timeout.

Test:

Log in, let the session run out, then click anything.

Before:

before

After:

after

New unit test:

PASS tests/unit/utils/request.spec.js
  ✓ shows a session expired warning when the session times out
  ✓ shows nothing when already on the login page

@codecov

codecov Bot commented Oct 8, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 20.22%. Comparing base (17294ca) to head (a8af602).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #14369      +/-   ##
============================================
+ Coverage     19.91%   20.22%   +0.30%     
- Complexity    20198    20744     +546     
============================================
  Files          6373     6426      +53     
  Lines        577234   580181    +2947     
  Branches      70696    71033     +337     
============================================
+ Hits         114945   117317    +2372     
- Misses       449724   450148     +424     
- Partials      12565    12716     +151
Flag Coverage Δ
uitests 3.82% <ø> (+0.12%) ⬆️
unittests 21.50% <ø> (+0.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@blueorangutan

blueorangutan commented Oct 8, 2026

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 19482

@Damans227
Damans227 marked this pull request as ready for review October 8, 2026 19:21
@sudo87

sudo87 commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

@blueorangutan ui

@blueorangutan

blueorangutan commented Oct 9, 2026

Copy link
Copy Markdown

@sudo87 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented Oct 9, 2026

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/14369 (QA-JID-1001)

sudo87
sudo87 reviewed Oct 9, 2026
View reviewed changes

@sudo87 sudo87 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, verified it

Screen.Recording.2026-10-09.at.12.39.47.PM.mov

@harikrishna-patnala

harikrishna-patnala commented Oct 12, 2026

Copy link
Copy Markdown
Member

@Damans227 @sudo87

There is an issue with 2FA wrong pin. After entering wrong PIN, the session popup window showed something and vanished. That needs fixing, not sure if it caused by this PR or #14054 cc @sudo87

2FA_error_message_failure.mp4

@harikrishna-patnala

harikrishna-patnala commented Oct 12, 2026

Copy link
Copy Markdown
Member

@sudo87 Before your commit, there is a popup "Unable to verify 2FA", but that also vanished very quickly, which needs fixing too.

2FA_popup_on_old_main.mp4

@Damans227 can you please correct these ?

@Damans227

Damans227 commented Oct 12, 2026

Copy link
Copy Markdown
Collaborator Author

@Damans227 can you please correct these ?

@harikrishna-patnala fixed both in a8af602. it was one bug from before this PR and #14054: the wrong pin error got cleared by the logout that runs right after it. now it shows once you land back on the login page, same for the 2FA setup page.

@Damans227

Damans227 commented Oct 12, 2026

Copy link
Copy Markdown
Collaborator Author

the failed component test isnt from this PR. test_03_delete_vm fails on the memory count, same as on #14384, and this PR only changes the UI.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sudo87 sudo87 sudo87 approved these changes
@harikrishna-patnala harikrishna-patnala Awaiting requested review from harikrishna-patnala

Assignees

No one assigned

Labels

component:UI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Damans227 @blueorangutan @sudo87 @harikrishna-patnala